Maniphest T94878

Line Art: Per object Override Crease setting does not work
Closed, Resolved
Actions

Assigned To
YimingWu (NicksBest)
Authored By
Elias Schwarze (eschwarze)
Jan 13 2022, 1:39 PM
Tags
  • BF Blender
  • Line Art
Subscribers
Elias Schwarze (eschwarze)
Pratik Borhade (PratikPB2123)
YimingWu (NicksBest)

Description

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.68

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: rBf1cca3055776
Caused by rBc1cf66bff3c0: LineArt: Automatic crease with flat/smooth faces.

Short description of error
When using the Line Art modifier to generate Outlines for a 3D Mesh, the "Override Crease" option in the object properties of each object does not affect line generation at all.

Exact steps for others to reproduce the error

  • Open attached .blend file
  • Switch to camera view
  • Select the Suzanne object
  • Go to the Line Art Panel in object properties
  • Activate the "Override Crease" option and increase or decrease the crease angle slider
  • This should generate either more or less outlines based on the angles of the individual polygons, however it does not appear to do anything

line_crease_test.blend1 MBDownload

Revisions and Commits

rB Blender
rB5079a460a748 Fix T94878: LineArt crease threshold logic error.
rB0cf746c1faff Fix T94878: LineArt crease threshold logic error.

Related Objects

Mentioned In
T93479: 3.0 Potential candidates for corrective releases
Mentioned Here
rB0cf746c1faff: Fix T94878: LineArt crease threshold logic error.
rBc1cf66bff3c0: LineArt: Automatic crease with flat/smooth faces.

Event Timeline

Elias Schwarze (eschwarze) created this task.Jan 13 2022, 1:39 PM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Jan 14 2022, 7:07 AM
Pratik Borhade (PratikPB2123) added a project: Line Art.
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).

Thanks for the report. I can confirm on current master.

Will bisect.

Pratik Borhade (PratikPB2123) triaged this task as High priority.Jan 14 2022, 10:10 AM
Pratik Borhade (PratikPB2123) added a subscriber: YimingWu (NicksBest).

Hi @YimingWu (NicksBest), can you look at this issue? Was appeared in rBc1cf66bff3c0: LineArt: Automatic crease with flat/smooth faces.
Regression and culprit commit is known so I am raising the priority (feel free to change)

Pratik Borhade (PratikPB2123) updated the task description.Jan 14 2022, 10:11 AM
YimingWu (NicksBest) claimed this task.Jan 14 2022, 1:59 PM

Hi I'll take a look.

YimingWu (NicksBest) closed this task as Resolved by committing rB0cf746c1faff: Fix T94878: LineArt crease threshold logic error..Jan 14 2022, 2:44 PM
YimingWu (NicksBest) added a commit: rB0cf746c1faff: Fix T94878: LineArt crease threshold logic error..
YimingWu (NicksBest) mentioned this in T93479: 3.0 Potential candidates for corrective releases.Jan 14 2022, 2:46 PM

Hi I have fixed the problem in master with 0cf746c1faff31e6e97789ffdd46206112ac81db.

Philipp Oeser (lichtwerk) added a commit: rB5079a460a748: Fix T94878: LineArt crease threshold logic error..Jan 17 2022, 1:25 PM