Maniphest T96163

Regression: Image editor fails to update after undoing stroke
Closed, Resolved
Actions

Assigned To
Jeroen Bakker (jbakker)
Authored By
Pratik Borhade (PratikPB2123)
Mar 4 2022, 12:47 PM
Tags
  • EEVEE & Viewport
  • BF Blender (3.1)
Subscribers
Jeroen Bakker (jbakker)
Pratik Borhade (PratikPB2123)
RedMser (RedMser)

Description

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: AMD Radeon(TM) 535 ATI Technologies Inc. 4.5.14831 Core Profile Context 21.5.2 27.20.21003.8013

Blender Version
Broken: version: master, 3.1.0
Initially caused by rB507a4deef149: Fix invalid creation of partial image updater

Short description of error
Image editor fails to update after undoing stroke.
Initially this was broken by rB507a4deef149 (but zooming or panning around used to update the editor)
After 5e9c1feb8aff0ca40eff6689f9bf6a9678711a9e this became more worse
And now it neither updates on pan or zoom

Exact steps for others to reproduce the error

  • Open .blend file
  • Draw a stoke in Image editor
  • Undo (Editor does not update)
  • Draw stroke around previous stroke

Test File:

tex-paint-undo.blend807 KBDownload

After rB507a4deef149After rB5e9c1feb8aff

Revisions and Commits

rB Blender
D14259rB073d2390f0b8 Fix T96163: Image editor doesn't refresh when undo/redo.

Related Objects

Mentioned In
T96324: Regression: Resizing an image is not correctly reflected in the image editor until the UI is updated
Mentioned Here
rB507a4deef149: Fix invalid creation of partial image updater
rB5e9c1feb8aff: Image Engine: Performance 8 byte images.

Event Timeline

Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Mar 4 2022, 12:47 PM
Pratik Borhade (PratikPB2123) triaged this task as High priority.
Pratik Borhade (PratikPB2123) created this task.
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) added a project: EEVEE & Viewport.
Pratik Borhade (PratikPB2123) added a subscriber: Jeroen Bakker (jbakker).

@Jeroen Bakker (jbakker) hi, can you check?
Raising the priority since it's a regression

Pratik Borhade (PratikPB2123) renamed this task from Image editor fails to update after undoing stroke to Regression: Image editor fails to update after undoing stroke.Mar 4 2022, 12:53 PM
Jeroen Bakker (jbakker) claimed this task.Mar 4 2022, 1:32 PM
Thomas Dinges (dingto) edited projects, added BF Blender (3.1); removed BF Blender.Mar 4 2022, 1:35 PM
Thomas Dinges (dingto) moved this task from Backlog to bcon4: Show Stoppers on the BF Blender (3.1) board.
RedMser (RedMser) added a subscriber: RedMser (RedMser).Mar 5 2022, 6:09 PM
Jeroen Bakker (jbakker) added a revision: D14259: Fix T96163: Image editor doesn't refresh when undo/redo..Mar 7 2022, 8:34 AM
Jeroen Bakker (jbakker) closed this task as Resolved by committing rB073d2390f0b8: Fix T96163: Image editor doesn't refresh when undo/redo..Mar 7 2022, 8:44 AM
Jeroen Bakker (jbakker) added a commit: rB073d2390f0b8: Fix T96163: Image editor doesn't refresh when undo/redo..
Pratik Borhade (PratikPB2123) mentioned this in T96324: Regression: Resizing an image is not correctly reflected in the image editor until the UI is updated.Mar 19 2022, 12:13 PM