Maniphest T96247

Different roughness values for default and new material
Closed, Resolved
Actions

Assigned To
Max Edge (bbbooo3)
Authored By
tamooz br (Koopa512)
Mar 8 2022, 10:32 PM
Tags
  • BF Blender
  • Nodes & Physics
  • EEVEE & Viewport
  • Good First Issue
Subscribers
Deyuan Liu (liudeyuan)
Pratik Borhade (PratikPB2123)
tamooz br (Koopa512)
Tyler (tsjordan)

Description

Blender Version
Broken: ac90c8a7743f
Worked: any older version

Short description of error
In this commit, the roughness on the default objects is at 0.4, while the default roughness for the Principled BSDF shader is 0.5.
This might've been caused by the default roughness for the viewport (workbench) being changed from 0.4 to 0.5.

Exact steps for others to reproduce the error

  • Load the default startup file,
  • Add new material (same for newly added Principled BSDF node)
  • Compare roughness value for default (0.4f) and recently added material (0.5f)

Revisions and Commits

rB Blender
D15586rB411b4ed6ed8f Fix T96247: Principled BSDF roughness different in startup blend and new node

Related Objects

Mentioned In
D15586: Fix T96247: different roughness values for default and new material
Mentioned Here
rBb646846646c2: Fix T92812: Startup has "Standard" View Transform Instead of "Filmic"

Event Timeline

tamooz br (Koopa512) created this task.Mar 8 2022, 10:32 PM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Mar 9 2022, 4:55 AM
Pratik Borhade (PratikPB2123) added a comment.Mar 9 2022, 5:03 AM

Hi, thanks for the report. If I understand correctly, this report is about different roughness value for default material(0.4f) and Principled BSDF node (0.5f)
Not a high priority bug though. It's been there for a quite long time (2.83.17 also has this issue)
Will make some edits in report before confirming.

Pratik Borhade (PratikPB2123) renamed this task from Default Cube and scuplting sphere roughness at 0.4 even though default principled bsdf is at 0.5 to Different roughness values for default and new material.Mar 9 2022, 5:19 AM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) added projects: Nodes & Physics, EEVEE & Viewport.
Clément Foucault (fclem) added a project: Good First Issue.May 10 2022, 4:19 PM
Max Edge (bbbooo3) claimed this task.May 30 2022, 8:49 AM
Max Edge (bbbooo3) added a comment.EditedMay 30 2022, 12:27 PM

@Pratik Borhade (PratikPB2123) This task refers to the roughness of the material of the default cube in the startup scene and the sphere in the sculpting template scene, which is 0.4 vs the 0.5 of the material added when clicking the New button on empty material slots in the materials tab. Additionally, the clipping threshold for the materials in those two scenes is 0.0 vs 0.5 for new materials.

Since I am new to blender dev, I am not sure how to proceed here. These scene files are not source code, but rather .blend files that are copy pasted into the final product. Thus, a .diff file will not suffice.

Tyler (tsjordan) added a subscriber: Tyler (tsjordan).May 31 2022, 5:47 AM

Is this as simple as opening release/datafiles/startup.blend with blender, changing the roughness to .5, then saving it? It looks like it was last saved in blender 3.0.0 in commit b646846646c2 in November, 2021. It's probably good to heed the advice in the commit:

commit b646846646c2adfe38a585f024f34ff388e221b8
Author: Hans Goudey <h.goudey@me.com>
Date:   Thu Nov 4 10:10:02 2021 -0500

    Fix T92812: Startup has "Standard" View Transform Instead of "Filmic"

    A repeat of the problem I caused last time I edited the startup file.
    Never do it with a lite build! Also align the toolbar widths in all
    editors to the smallest size they snap to.
Max Edge (bbbooo3) added a comment.Jun 1 2022, 7:49 PM
In T96247#1366982, @Tyler (tsjordan) wrote:

Is this as simple as opening release/datafiles/startup.blend with blender, changing the roughness to .5, then saving it?

Yes.

Deyuan Liu (liudeyuan) added a subscriber: Deyuan Liu (liudeyuan).Jul 22 2022, 11:14 AM
Deyuan Liu (liudeyuan) added a comment.Jul 31 2022, 10:23 AM

We need to change default roughness from 0.4 to 0.5, or change new material roughness from 0.5 to 0.4?

If the former is true, we need to change default roughness via code, or we can change default roughness via edit startup.blend?

Deyuan Liu (liudeyuan) mentioned this in D15586: Fix T96247: different roughness values for default and new material.Jul 31 2022, 11:58 AM
Iliya Katueshenock (Moder) added a revision: D15586: Fix T96247: different roughness values for default and new material.Jul 31 2022, 12:35 PM
Brecht Van Lommel (brecht) closed this task as Resolved by committing rB411b4ed6ed8f: Fix T96247: Principled BSDF roughness different in startup blend and new node.Aug 3 2022, 7:55 PM
Brecht Van Lommel (brecht) added a commit: rB411b4ed6ed8f: Fix T96247: Principled BSDF roughness different in startup blend and new node.