Maniphest T96255

Node socket click detection is broken in some cases
Closed, ResolvedBUG
Actions

Assigned To
Campbell Barton (campbellbarton)
Authored By
Hallam Roberts (MysteryPancake)
Mar 9 2022, 9:18 AM
Tags
  • BF Blender
  • Geometry Nodes
  • Nodes & Physics
  • User Interface
Subscribers
Campbell Barton (campbellbarton)
Daniel Bohn (dabo)
Daniel Paul (DaPaulus)
Fabrizio (faber)
Germano Cavalcante (mano-wii)
Hallam Roberts (MysteryPancake)
HEYPictures (HEYPictures)
8 More Subscribers
Tokens
"Burninate" token, awarded by HEYPictures."Like" token, awarded by lars_cawley."Like" token, awarded by dabo."Love" token, awarded by Erindale.

Description

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.79

Blender Version
Broken: version: 3.2.0 Alpha, branch: master (modified), commit date: 2022-03-09 06:18, hash: rB1f9d85f56aac
broke recently between eabdcdcd44b9 - 0a4fdcbb5fe3
Possibly caused by rBaa71414dfca7: Fix click-drag events for dragging markers?

Short description of error
The click detection for nodes does not always work correctly.

Exact steps for others to reproduce the error

  1. Set Blender's interface scale to 2.0 (not required)
  2. Zoom in and out on any node tree while attempting to click and drag the sockets.
  3. Notice sometimes the click is not registered.

Does not seem to affect other node trees apart from Geometry Nodes.

Revisions and Commits

rB Blender
rBfb8757869871 Fix T96255: Node socket fails to drag

Related Objects

Mentioned In
T96600: Difficulties in pulling out noodles from a socket of a node
T96520: Regression: Node editor: Tweak is broken and requires click, then click again to drag
T96468: Can't drag noodles in geometry nodes editor
T96244: Node Editor selection.
Mentioned Here
rBeabdcdcd44b9: Merge remote-tracking branch 'origin/blender-v3.1-release'
rB0a4fdcbb5fe3: Cleanup: unused Python variables & imports
rBaa71414dfca7: Fix click-drag events for dragging markers
T96244: Node Editor selection.

Event Timeline

Hallam Roberts (MysteryPancake) created this task.Mar 9 2022, 9:18 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Mar 9 2022, 10:21 AM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Mar 9 2022, 10:28 AM

Thanks for the report. I can confirm.
Definitely a regression but can not replicate on 3.1. Will check where exactly it broke.
Also, similar report we've got already but I'm not sure if it's related to this one- T96244: Node Editor selection.

Pratik Borhade (PratikPB2123) added projects: Geometry Nodes, Nodes & Physics, User Interface.Mar 9 2022, 12:18 PM

At the end, git bisect points me to rBaa71414dfca7: Fix click-drag events for dragging markers
Though I'm not very sure, I caught with random crashes on intermediate builds (due to some recent changes in drag event)
@Hallam Roberts (MysteryPancake) , did you find the same behavior with other node editors.

Hallam Roberts (MysteryPancake) added a comment.EditedMar 9 2022, 12:24 PM
In T96255#1319308, @Pratik Borhade (PratikPB2123) wrote:

At the end, git bisect points me to rBaa71414dfca7: Fix click-drag events for dragging markers
Though I'm not very sure, I caught with random crashes on intermediate builds (due to some recent changes in drag event)
@Hallam Roberts (MysteryPancake) , did you find the same behavior with other node editors.

It doesn't seem to affect other node editors for some reason. It doesn't appear to happen in Blender 3.0 either.

Steffen Dünner (SteffenD) added a subscriber: Steffen Dünner (SteffenD).Mar 9 2022, 12:25 PM
Pratik Borhade (PratikPB2123) triaged this task as High priority.EditedMar 9 2022, 12:34 PM
Pratik Borhade (PratikPB2123) added a subscriber: Campbell Barton (campbellbarton).

It doesn't seem to affect other node editors for some reason.

Ok, thanks you for information.

It doesn't appear to happen in Blender 3.0 either.

Yes, broke recently between eabdcdcd44b9 - 0a4fdcbb5fe3
@Campbell Barton (campbellbarton) , can you take a look? (uncertain about problematic commit)

(4k monitor requirement is misleading. I can even reproduce on normal monitor)

Pratik Borhade (PratikPB2123) renamed this task from Node socket click detection is broken on 4K monitor with interface scale 2.0 to Node socket click detection is broken in some cases.Mar 9 2022, 12:39 PM
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) updated the task description.Mar 9 2022, 12:42 PM
Raimund Klink (Raimund58) added a subscriber: Raimund Klink (Raimund58).Mar 9 2022, 1:36 PM
Erindale (Erindale) awarded a token.Mar 10 2022, 3:59 PM
Pratik Borhade (PratikPB2123) mentioned this in T96244: Node Editor selection..Mar 11 2022, 2:19 PM
Daniel Bohn (dabo) awarded a token.Mar 14 2022, 10:09 AM
Daniel Bohn (dabo) added a subscriber: Daniel Bohn (dabo).
Daniel Paul (DaPaulus) added a subscriber: Daniel Paul (DaPaulus).Mar 14 2022, 4:31 PM
Lars Cawley (lars_cawley) awarded a token.Mar 15 2022, 8:46 AM
Lars Cawley (lars_cawley) added a subscriber: Lars Cawley (lars_cawley).
Hans Goudey (HooglyBoogly) changed the subtype of this task from "Report" to "Bug".Mar 15 2022, 6:02 PM
HEYPictures (HEYPictures) added a subscriber: HEYPictures (HEYPictures).Mar 15 2022, 7:46 PM

I also have the same problem but I have the scale set to one and I also have to try like 3 times sometimes to drag a noodle out of a soccet.

HEYPictures (HEYPictures) awarded a token.Mar 15 2022, 7:46 PM
ilir beqiri (ilirbeqiri) added a subscriber: ilir beqiri (ilirbeqiri).Mar 16 2022, 12:06 AM
Pratik Borhade (PratikPB2123) mentioned this in T96468: Can't drag noodles in geometry nodes editor.Mar 16 2022, 1:56 PM
Pratik Borhade (PratikPB2123) mentioned this in T96520: Regression: Node editor: Tweak is broken and requires click, then click again to drag.Mar 16 2022, 2:20 PM
Daniel Bohn (dabo) added a comment.Mar 16 2022, 10:36 PM

I'm facing the same issue, it only works if I offset my cursor to the left.
Problem occurs on 4k and 1080p, resolution scale is set to 1.

Richard Antalik (ISS) merged a task: T96468: Can't drag noodles in geometry nodes editor.Mar 16 2022, 11:26 PM
Richard Antalik (ISS) added subscribers: Pascal (PMA33), Richard Antalik (ISS), Philipp Oeser (lichtwerk).
Hallam Roberts (MysteryPancake) updated the task description.Mar 17 2022, 10:16 AM
Hallam Roberts (MysteryPancake) updated the task description.Mar 17 2022, 10:45 AM
Hallam Roberts (MysteryPancake) added a comment.EditedMar 17 2022, 12:05 PM

I noticed when the bug occurs, the socket is clickable further to the left but not on the socket itself. Also node_link_invoke is never called when the bug occurs.

Germano Cavalcante (mano-wii) mentioned this in T96600: Difficulties in pulling out noodles from a socket of a node.Mar 18 2022, 6:59 PM
Germano Cavalcante (mano-wii) merged a task: T96600: Difficulties in pulling out noodles from a socket of a node.
Germano Cavalcante (mano-wii) added subscribers: Fabrizio (faber), Germano Cavalcante (mano-wii).
Wade Lees (wlees) added a subscriber: Wade Lees (wlees).Mar 19 2022, 9:55 PM
Campbell Barton (campbellbarton) closed this task as Resolved by committing rBfb8757869871: Fix T96255: Node socket fails to drag.Mar 21 2022, 8:21 AM
Campbell Barton (campbellbarton) claimed this task.
Campbell Barton (campbellbarton) added a commit: rBfb8757869871: Fix T96255: Node socket fails to drag.
ilir beqiri (ilirbeqiri) added a comment.Mar 21 2022, 5:11 PM

Thank you @Campbell Barton (campbellbarton) !