Maniphest T96324

Regression: Resizing an image is not correctly reflected in the image editor until the UI is updated
Closed, Resolved
Actions

Assigned To
Jeroen Bakker (jbakker)
Authored By
Alaska (Alaska)
Mar 11 2022, 7:15 AM
Tags
  • BF Blender
  • EEVEE & Viewport
Subscribers
Alaska (Alaska)
Francois (FRworld)
Jeroen Bakker (jbakker)
Pratik Borhade (PratikPB2123)

Description

System Information
Operating system: Linux-5.16.0-3-amd64-x86_64-with-glibc2.33 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 510.54

Blender Version
Broken version: 3.2.0 Alpha, branch: master, commit date: 2022-03-11 04:29, hash: rBf6564df3515f
Broken version: 3.1 Release
Worked: All versions prior to commit rB5e9c1feb8aff: Image Engine: Performance 8 byte images.

Short description of error
Resizing an image in the image editor will not update correct. A correct update will occur once the UI is changed. This may be related to T96312: Regression: Image Editor Flip option isn't working and T96323: Regression: Invert colour is not reflected in the image viewer until a UI change

Here is a video demonstrating the issue:

Exact steps for others to reproduce the error

  1. Load an image in the image editor.
  2. Select from the top Image → Resize and change the size of the image.
  3. Notice how the image has not been properly updated. Split the editor and the image will update to the correct result.

Revisions and Commits

rB Blender
rBf6e2c9bc97d2 Image editor: not updating after image operation.
rB2fc77071b51a Image editor: not updating after image operation.

Related Objects

Mentioned In
T96241: 3.1: Potential candidates for corrective releases
P2839 3.1 R
T96355: Image editor commands not working properly - Gives glitchy results
Mentioned Here
T96163: Regression: Image editor fails to update after undoing stroke
rB5e9c1feb8aff: Image Engine: Performance 8 byte images.
rBeb0f8317e231: Cleanup: ED_view3d_win_to_delta & ED_view3d_calc_zfac usage
rBeabdcdcd44b9: Merge remote-tracking branch 'origin/blender-v3.1-release'
T96312: Regression: Image Editor Flip option isn't working
T96323: Regression: Invert colour is not reflected in the image viewer until a UI change
rB507a4deef149: Fix invalid creation of partial image updater

Event Timeline

Alaska (Alaska) created this task.Mar 11 2022, 7:15 AM
Alaska (Alaska) added a subscriber: Jeroen Bakker (jbakker).

CC @Jeroen Bakker (jbakker) as you worked on a fix for a similar issue.

Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Mar 11 2022, 8:06 AM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Mar 11 2022, 8:10 AM
Pratik Borhade (PratikPB2123) triaged this task as High priority.
Pratik Borhade (PratikPB2123) added a project: EEVEE & Viewport.

Worked: Presumably prior to rB507a4deef149

Not this time :)
This is actually broke between eb0f8317e231 - eabdcdcd44b9

Alaska (Alaska) added a comment.EditedMar 11 2022, 10:21 AM

You're right, it is caused by rB5e9c1feb8aff: Image Engine: Performance 8 byte images. instead

Alaska (Alaska) updated the task description.Mar 11 2022, 10:21 AM
Alaska (Alaska) mentioned this in T96355: Image editor commands not working properly - Gives glitchy results.Mar 12 2022, 2:26 AM
Francois (FRworld) added a subscriber: Francois (FRworld).Mar 12 2022, 7:11 AM
Pratik Borhade (PratikPB2123) added a comment.Mar 19 2022, 12:13 PM

Following change fixes the issue for me. This is same as the fix of T96163

diff --git a/source/blender/editors/space_image/image_ops.c b/source/blender/editors/space_image/image_ops.c
index 3721ea81c04..b48ec4be24c 100644
--- a/source/blender/editors/space_image/image_ops.c
+++ b/source/blender/editors/space_image/image_ops.c
@@ -2992,7 +2992,7 @@ static int image_scale_exec(bContext *C, wmOperator *op)
   ED_image_undo_push_end();

   /* Force GPU re-upload, all image is invalid. */
-  BKE_image_free_gputextures(ima);
+  BKE_image_partial_update_mark_full_update(ima);

   DEG_id_tag_update(&ima->id, 0);
   WM_event_add_notifier(C, NC_IMAGE | NA_EDITED, ima);
Pratik Borhade (PratikPB2123) mentioned this in P2839 3.1 R.Mar 20 2022, 12:20 PM
Philipp Oeser (lichtwerk) renamed this task from Resizing an image is not correctly reflected in the image editor until the UI is updated to Regression: Resizing an image is not correctly reflected in the image editor until the UI is updated.Mar 22 2022, 4:06 PM
Dalai Felinto (dfelinto) assigned this task to Jeroen Bakker (jbakker).Mar 25 2022, 4:10 PM
Jeroen Bakker (jbakker) closed this task as Resolved by committing rB2fc77071b51a: Image editor: not updating after image operation..Mar 25 2022, 4:38 PM
Jeroen Bakker (jbakker) added a commit: rB2fc77071b51a: Image editor: not updating after image operation..
Jeroen Bakker (jbakker) mentioned this in T96241: 3.1: Potential candidates for corrective releases.Mar 25 2022, 4:41 PM
Philipp Oeser (lichtwerk) added a commit: rBf6e2c9bc97d2: Image editor: not updating after image operation..Mar 28 2022, 4:27 PM