Maniphest T96401

Bake normals for multi-resolution object is broken
Closed, Resolved
Actions

Assigned To
Hans Goudey (HooglyBoogly)
Authored By
CHET (cheteron)
Mar 13 2022, 4:04 PM
Tags
  • BF Blender
  • Render & Cycles
  • Modeling
Subscribers
CHET (cheteron)
Hans Goudey (HooglyBoogly)
Philipp Oeser (lichtwerk)
Pratik Borhade (PratikPB2123)

Description

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 950M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.13

Blender Version
Broken: version: 3.1.0, branch: master, commit date: 2022-03-08 18:16, hash: rBc77597cd0e15
Worked: 3.0.0

Caused by rBa81cc5cbcb6c: Fix: Avoid potential use of dirty normals

Already not in the first version, the problem with baking. Once it was fixed, now it has appeared in a new version, stable!
Question to the developers, how do you even fix bugs if old bugs pop up, and why do you release stable versions when they have such critical bugs?! Why don't you test what you release?

Steps to Reproduce

  • Open .blend file and bake image texture

3.blend2 MBDownload

Revisions and Commits

rB Blender
rB07dc383f4b19 Fix T96401: Broken multires baked normals result
rB3a8a7d93f927 Fix T96401: Broken multires baked normals result

Related Objects

Mentioned In
T96241: 3.1: Potential candidates for corrective releases
T96670: Regression: Blender 3.1 bake from multires not reflected in the Image Editor
P2839 3.1 R
Mentioned Here
T96670: Regression: Blender 3.1 bake from multires not reflected in the Image Editor
rBa81cc5cbcb6c: Fix: Avoid potential use of dirty normals
rB9153bf24cbf2: Merge branch 'blender-v3.1-release'
rBfcda858e3200: Cleanup: remove Python 3.9 annotation workarounds

Event Timeline

CHET (cheteron) created this task.Mar 13 2022, 4:04 PM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Mar 21 2022, 7:47 AM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.EditedMar 21 2022, 8:11 AM
Pratik Borhade (PratikPB2123) added a project: Render & Cycles.

Thanks for the report. Bake normals seems not working correctly.
Broke between 9153bf24cbf2 - fcda858e3200

Pratik Borhade (PratikPB2123) renamed this task from Baking bug in 3.1 to Bake normals for multi-resolution object is broken.Mar 21 2022, 8:14 AM
Pratik Borhade (PratikPB2123) triaged this task as High priority.
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) mentioned this in P2839 3.1 R.Mar 21 2022, 8:24 AM
Pratik Borhade (PratikPB2123) mentioned this in T96670: Regression: Blender 3.1 bake from multires not reflected in the Image Editor.Mar 21 2022, 4:32 PM
Philipp Oeser (lichtwerk) added a project: Modeling.Mar 21 2022, 4:42 PM
Philipp Oeser (lichtwerk) added subscribers: Hans Goudey (HooglyBoogly), Philipp Oeser (lichtwerk).

Caused by rBa81cc5cbcb6c: Fix: Avoid potential use of dirty normals

CC @Hans Goudey (HooglyBoogly)

Philipp Oeser (lichtwerk) updated the task description.Mar 21 2022, 4:42 PM
Hans Goudey (HooglyBoogly) added a comment.EditedMar 21 2022, 10:16 PM

This bisect and the "caused by" commit doesn't seem to add up to me. I tried it on 3.0, and when I pressed the "Bake" button, the black texture is replaced by the baked result.
In 3.1, pressing "Bake" does nothing to the texture, it remains black. However, the commit before rBa81cc5cbcb6c: Fix: Avoid potential use of dirty normals also has this problem, as does @Pratik Borhade (PratikPB2123)'s "good" commit, 9153bf24cbf2.

I tried going further back, but I get build errors after a certain point.

Am I doing something wrong? Do I need to do something besides pressing "Bake"?

Hans Goudey (HooglyBoogly) added a comment.Mar 21 2022, 10:29 PM

Okay, it seems the image editor just doesn't update in 3.1, but the bake is still changing the image. Maybe that's another bug? I can reproduce this!

Hans Goudey (HooglyBoogly) closed this task as Resolved by committing rB3a8a7d93f927: Fix T96401: Broken multires baked normals result.Mar 21 2022, 10:56 PM
Hans Goudey (HooglyBoogly) claimed this task.
Hans Goudey (HooglyBoogly) added a commit: rB3a8a7d93f927: Fix T96401: Broken multires baked normals result.
Hans Goudey (HooglyBoogly) mentioned this in T96241: 3.1: Potential candidates for corrective releases.Mar 21 2022, 11:00 PM
Pratik Borhade (PratikPB2123) added a comment.Mar 22 2022, 3:58 AM

Okay, it seems the image editor just doesn't update in 3.1. Maybe that's another bug

Yes, we have a separate report for it: T96670: Regression: Blender 3.1 bake from multires not reflected in the Image Editor

Philipp Oeser (lichtwerk) added a commit: rB07dc383f4b19: Fix T96401: Broken multires baked normals result.Mar 24 2022, 9:07 AM