Maniphest T96417

Multiscatter GGX regression with non-zero roughness and a bump texture on a non-manifold object
Closed, ResolvedBUG
Actions

Assigned To
Brecht Van Lommel (brecht)
Authored By
Lt Knb (Lt-knb)
Mar 14 2022, 4:13 AM
Tags
  • BF Blender
  • Render & Cycles
Subscribers
Alaska (Alaska)
Brecht Van Lommel (brecht)
Lt Knb (Lt-knb)
Pratik Borhade (PratikPB2123)
William Leeson (leesonw)

Description

System Information
Operating system: Windows 10 1909
Graphics card: GTX 1070 496.13

Blender Version
Broken: 3.1 Stable
Worked: 3.0.1
Caused by rBae4407034114: Cycles: explicitly skip self-intersection

Short description of error
When set to Multiscatter GGX, a non-manifold object with a bump texture and a non-zero roughness behaves as if light "passes through it" (the softboxes).
The stripes on the curved plane can only be fixed by making it manifold, afaik (It's a separate issue, I guess)

Expected behavior, 3.0.1

3.1

Exact steps for others to reproduce the error
Press F12 in my test file

MSGGX.blend967 KBDownload

Revisions and Commits

rB Blender
rBeb605ba78808 Fix T96417: Cycles issue with multiscatter GGX and self intersection avoidance
rBaf51b0d8d880 Fix T96417: Cycles issue with multiscatter GGX and self intersection avoidance

Related Objects

Mentioned In
T96241: 3.1: Potential candidates for corrective releases
Mentioned Here
rBae4407034114: Cycles: explicitly skip self-intersection

Event Timeline

Lt Knb (Lt-knb) created this task.Mar 14 2022, 4:13 AM
Lt Knb (Lt-knb) updated the task description.Mar 14 2022, 4:26 AM
Alaska (Alaska) changed the task status from Needs Triage to Confirmed.Mar 14 2022, 4:49 AM
Alaska (Alaska) added a project: Render & Cycles.
Alaska (Alaska) changed the subtype of this task from "Report" to "Bug".
Alaska (Alaska) added subscribers: William Leeson (leesonw), Brecht Van Lommel (brecht), Alaska (Alaska).

I can reproduce this issue with the setup below.

I should note that this issue was caused by this commit: rBae4407034114: Cycles: explicitly skip self-intersection

CC @Brecht Van Lommel (brecht) and @William Leeson (leesonw)

System Information
Operating system: Linux-5.16.0-3-amd64-x86_64-with-glibc2.33 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 510.54
Blender version: 3.2.0 Alpha, branch: master, commit date: 2022-03-12 10:29, hash: rBf6b73966101d

Alaska (Alaska) updated the task description.Mar 14 2022, 4:49 AM
Pratik Borhade (PratikPB2123) triaged this task as High priority.Mar 14 2022, 5:14 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).
Alaska (Alaska) updated the task description.Mar 14 2022, 5:17 AM
Brecht Van Lommel (brecht) closed this task as Resolved by committing rBaf51b0d8d880: Fix T96417: Cycles issue with multiscatter GGX and self intersection avoidance.Mar 15 2022, 4:29 PM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) added a commit: rBaf51b0d8d880: Fix T96417: Cycles issue with multiscatter GGX and self intersection avoidance.
Brecht Van Lommel (brecht) mentioned this in T96241: 3.1: Potential candidates for corrective releases.Mar 15 2022, 6:48 PM
Philipp Oeser (lichtwerk) added a commit: rBeb605ba78808: Fix T96417: Cycles issue with multiscatter GGX and self intersection avoidance.Mar 21 2022, 2:07 PM
Lt Knb (Lt-knb) added a comment.Mar 25 2022, 2:14 PM
This comment was removed by Lt Knb (Lt-knb).