Maniphest T96543

Panning Broken in the Image Editor (Image Editor: Incorrect Image Offsets)
Closed, ResolvedBUG
Actions

Assigned To
Habib Gahbiche (zazizizou)
Authored By
Ethan Hall (Ethan1080)
Mar 17 2022, 5:56 AM
Tags
  • BF Blender
  • EEVEE & Viewport
Subscribers
Dalai Felinto (dfelinto)
Ethan Hall (Ethan1080)
Guido (Nurb2Kea)
Habib Gahbiche (zazizizou)
Ilia (reightar)
Jeroen Bakker (jbakker)
kursad k (kursadk)
6 More Subscribers

Description

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-16 23:08, hash: rBea0c86e961de
Caused by rB33409f9f1cd4: Compositor: Support backdrop offset for the Viewer node

Short description of error
The image offsets are incorrectly calculated for the image editor.
This is the cause of a few problems.
Most notably, panning is broken in the image editor.

Steps to Reproduce
Just add any image in UV/Image editor and try to pan it

Revisions and Commits

rB Blender
rB7fed213ba40d Revert "Compositor: Support backdrop offset for the Viewer node"

Related Objects

Event Timeline

Ethan Hall (Ethan1080) created this task.Mar 17 2022, 5:56 AM
Ethan Hall (Ethan1080) updated the task description.
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Mar 17 2022, 6:23 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).

Hi, thanks for the report.
Is broken, yes. Will check if that commit is actually responsible for this issue to happen. (Zoom operation is also affected)

Ethan Hall (Ethan1080) added a comment.Mar 17 2022, 6:28 AM

https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/image/image_space_image.hh$166-167

Removing the the offset_x and offset_y from these two lines seems to fix it.
I am not sure about what changing this breaks though.

Ethan Hall (Ethan1080) added a subscriber: Jeroen Bakker (jbakker).Mar 17 2022, 6:42 AM

After removing these offsets, the compositor and image editor both seemed to work like normal.

Since I do not know why these offsets were calculated or what they were intended for, @Jeroen Bakker (jbakker) should take a look at it.

Pratik Borhade (PratikPB2123) triaged this task as High priority.Mar 17 2022, 7:07 AM
Pratik Borhade (PratikPB2123) added a project: EEVEE & Viewport.
Pratik Borhade (PratikPB2123) added a subscriber: Habib Gahbiche (zazizizou).

Yes, that commit is responsible.
Also poking @Habib Gahbiche (zazizizou)

Ethan Hall (Ethan1080) added a comment.EditedMar 17 2022, 7:12 AM

Also, note that there is an indention error in that same block of code.
And a space in sima ->zoom

Pratik Borhade (PratikPB2123) assigned this task to Habib Gahbiche (zazizizou).Mar 17 2022, 9:58 AM
Pratik Borhade (PratikPB2123) mentioned this in T96549: Image/UV editor pan problem.Mar 17 2022, 10:03 AM
Pratik Borhade (PratikPB2123) merged a task: T96549: Image/UV editor pan problem.
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) added a subscriber: Ilia (reightar).
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Mar 17 2022, 10:59 AM
Dalai Felinto (dfelinto) changed the subtype of this task from "Report" to "Bug".Mar 17 2022, 11:06 AM

Confirmed here as well.

Pratik Borhade (PratikPB2123) mentioned this in T96554: No more panning in Image Editor.Mar 17 2022, 12:08 PM
Pratik Borhade (PratikPB2123) merged a task: T96554: No more panning in Image Editor.
Pratik Borhade (PratikPB2123) added a subscriber: Steffen Dünner (SteffenD).
Jesse Yurkovich (deadpin) merged a task: T96570: Image editor pan and zoom stopped working.Mar 17 2022, 8:04 PM
Jesse Yurkovich (deadpin) added a subscriber: Mariano Basti (marianobasti).
Jesse Yurkovich (deadpin) merged a task: T96578: Image Editor images can NOT be moved anymore.Mar 18 2022, 2:54 AM
Jesse Yurkovich (deadpin) added a subscriber: Guido (Nurb2Kea).
Pratik Borhade (PratikPB2123) mentioned this in T96592: Images don't move in image editor using middle mouse click.Mar 18 2022, 12:12 PM
Pratik Borhade (PratikPB2123) merged a task: T96592: Images don't move in image editor using middle mouse click.
Pratik Borhade (PratikPB2123) added a subscriber: Shady Hamza (Shady.Hamza).
Jesse Yurkovich (deadpin) merged a task: T96597: Render Result moving with MMB broken.Mar 18 2022, 6:40 PM
Jesse Yurkovich (deadpin) added subscribers: user1 (user1), ogierm.
Lloyd (digim0nk) mentioned this in T96607: Panning images in the image viewer is broken.Mar 18 2022, 7:01 PM
Jesse Yurkovich (deadpin) merged a task: T96607: Panning images in the image viewer is broken.Mar 18 2022, 7:01 PM
Jesse Yurkovich (deadpin) added subscribers: kursad k (kursadk), Lloyd (digim0nk).
kursad k (kursadk) added a comment.EditedMar 18 2022, 7:08 PM

Centering the images with the home key is also broken, I am guessing they are related.

Ethan Hall (Ethan1080) renamed this task from Panning Broken in the Image Editor to Panning Broken in the Image Editor (Image Editor: Incorrect Image Offsets).Mar 19 2022, 12:12 AM
Ethan Hall (Ethan1080) updated the task description.
Brecht Van Lommel (brecht) closed this task as Resolved by committing rB7fed213ba40d: Revert "Compositor: Support backdrop offset for the Viewer node".Mar 19 2022, 12:42 AM
Brecht Van Lommel (brecht) added a commit: rB7fed213ba40d: Revert "Compositor: Support backdrop offset for the Viewer node".
Ethan Hall (Ethan1080) mentioned this in D12750: Compositor: Support backdrop offset for the Viewer node.Mar 19 2022, 7:54 PM