Maniphest T96655

[EEVEE] Enabling Bloom Crashes Blender
Closed, Resolved

Assigned To
Clément Foucault (fclem)
Authored By
Hector DeAnda (Hector123)
Mar 20 2022, 6:26 PM
Tags
  • BF Blender
  • EEVEE & Viewport
Subscribers
Daniel Salazar (zanqdo)
Gernot Buder (budger)
Hallam Roberts (MysteryPancake)
Hector DeAnda (Hector123)
Jesse Yurkovich (deadpin)
Lloyd (digim0nk)
Richard Antalik (ISS)
2 More Subscribers

Description

System Information
Operating system: macOS-12.3-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon HD - FirePro D500 OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.8.13

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-19 21:14, hash: rB5bfdaaa80082
Worked: (newest version of Blender that worked as expected)

Short description of error
Enabling Bloom in Eeevee and going in to Rendered mode crashes Blender.

Exact steps for others to reproduce the error

  1. Open General template
  2. Go to Rendered Mode.
  3. Enable Bloom in Eevee.
  4. Crash.

Revisions and Commits

rB Blender
Concern RaisedD14396

Event Timeline

Hector DeAnda (Hector123) created this task.Mar 20 2022, 6:26 PM

Worked on previous day's version.

Richard Antalik (ISS) changed the task status from Needs Triage to Confirmed.Mar 20 2022, 9:32 PM
Richard Antalik (ISS) triaged this task as High priority.
Richard Antalik (ISS) added a project: EEVEE & Viewport.
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).

Exception thrown: read access violation. blender::gpu::unwrap(...) returned nullptr.

>	blender.exe!GPU_shader_get_builtin_block(GPUShader * shader, int builtin) Line 566	C++
 	blender.exe!drw_shgroup_init(DRWShadingGroup * shgroup, GPUShader * shader) Line 1366	C
 	blender.exe!DRW_shgroup_create(GPUShader * shader, DRWPass * pass) Line 1562	C
 	blender.exe!eevee_create_bloom_pass(const unsigned char * name, EEVEE_EffectsInfo * effects, GPUShader * sh, DRWPass * * pass, bool upsample, bool resolve) Line 134	C
 	blender.exe!EEVEE_bloom_cache_init(EEVEE_ViewLayerData * UNUSED_sldata, EEVEE_Data * vedata) Line 197	C
 	blender.exe!eevee_cache_init(void * vedata) Line 84	C
 	blender.exe!drw_engines_cache_init() Line 1023	C
 	blender.exe!DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1659	C
 	blender.exe!DRW_draw_view(const bContext * C) Line 1588	C
 	blender.exe!view3d_draw_view(const bContext * C, ARegion * region) Line 1541	C
 	blender.exe!view3d_main_region_draw(const bContext * C, ARegion * region) Line 1564	C
 	blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 547	C
 	blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 716	C
 	blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 868	C
 	blender.exe!wm_draw_update(bContext * C) Line 1067	C
 	blender.exe!WM_main(bContext * C) Line 630	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 551	C
 	[External Code]

Caused by 472fc0c55848b2e2d428cfb4f7debb80a4e12081

Richard Antalik (ISS) renamed this task from Crashes when opening "Party Tug" blend file by Ian Hubert to [EEVEE] Enabling Bloom Crashes Blender.Mar 20 2022, 9:40 PM
Richard Antalik (ISS) merged a task: T96660: [EEVEE] Enabling Bloom Crashes Blender.
Richard Antalik (ISS) updated the task description.
Richard Antalik (ISS) added a subscriber: Wykrhm Reddy (wykrhm).
Robert Stockton (stocktonrgs) added a subscriber: Robert Stockton (stocktonrgs).Mar 21 2022, 3:26 AM
Hallam Roberts (MysteryPancake) added a subscriber: Hallam Roberts (MysteryPancake).EditedMar 21 2022, 5:45 AM

The error occurs because vec3 safe_color(vec3 c) is now duplicated code within effect_bloom_frag.glsl and common_math_lib.glsl

The duplicate code can now be deleted from effect_bloom_frag.glsl.

Opened a patch: D14396

Hallam Roberts (MysteryPancake) added a revision: D14396: Fix T96655: Bloom crashes Eevee.Mar 21 2022, 5:51 AM
Jesse Yurkovich (deadpin) added a subscriber: Gernot Buder (budger).
Clément Foucault (fclem) closed this task as Resolved by committing rBc5456819ee49: Fix T96655: Bloom crashes Eevee.Mar 21 2022, 1:20 PM
Clément Foucault (fclem) claimed this task.
Clément Foucault (fclem) added a commit: rBc5456819ee49: Fix T96655: Bloom crashes Eevee.
Daniel Salazar (zanqdo) added subscribers: user1 (user1), Jesse Yurkovich (deadpin), Daniel Salazar (zanqdo).
Jesse Yurkovich (deadpin) added a subscriber: Lloyd (digim0nk).