Maniphest T96828

Regression: GPencil primitives handlers not working
Closed, ResolvedBUG
Actions

Assigned To
Antonio Vazquez (antoniov)
Authored By
Antonio Vazquez (antoniov)
Mar 28 2022, 12:56 PM
Tags
  • BF Blender
Subscribers
Antonio Vazquez (antoniov)
Campbell Barton (campbellbarton)
Matias Mendiola (mendio)

Description

Tested using last master code on Windows

To reproduce:

  1. Open 2D Template
  2. Draw a Primitive curve
  3. Try to use the handler points.

The problem was produced by commit 52af3b20d45ea525a0ce66b2613ac132c9032a3f

Cleanup: cursor motion events now have value set to KM_NOTHING

The problem is the event->val is set to KM_NOTHING, but the primitive need to check that the mouse is moving and also that mouse button is pressed.

The line with the problem is 1484 in gpencil_primitive.c

if ((event->val == KM_PRESS) && tgpi->sel_cp != SELECT_NONE) {

Revisions and Commits

rB Blender
rBbac78e9bbe1f Fix T96828: GPencil primitives handlers not working
rBe6dfe570cc00 Fix T96828: GPencil primitives handlers not working

Related Objects

Mentioned In
T96241: 3.1: Potential candidates for corrective releases
Mentioned Here
rB52af3b20d45e: Cleanup: cursor motion events now have value set to KM_NOTHING

Event Timeline

Antonio Vazquez (antoniov) changed the task status from Needs Triage to Confirmed.Mar 28 2022, 12:56 PM
Antonio Vazquez (antoniov) created this task.
Antonio Vazquez (antoniov) changed the subtype of this task from "Report" to "Bug".
Antonio Vazquez (antoniov) edited projects, added BF Blender; removed Add-ons (Community).
Antonio Vazquez (antoniov) added a subscriber: Campbell Barton (campbellbarton).

@Campbell Barton (campbellbarton) could you look at this regresion? I don't know how check now if the mouse is moving and the mouse button is pressed.

Antonio Vazquez (antoniov) updated the task description.Mar 28 2022, 12:57 PM
Antonio Vazquez (antoniov) added a subscriber: Matias Mendiola (mendio).
Antonio Vazquez (antoniov) claimed this task.Mar 28 2022, 1:09 PM
Antonio Vazquez (antoniov) closed this task as Resolved by committing rBe6dfe570cc00: Fix T96828: GPencil primitives handlers not working.Mar 28 2022, 1:12 PM
Antonio Vazquez (antoniov) added a commit: rBe6dfe570cc00: Fix T96828: GPencil primitives handlers not working.
Antonio Vazquez (antoniov) renamed this task from Regresion: GPencil primitives handlers not working to Regression: GPencil primitives handlers not working.Mar 28 2022, 1:14 PM
Antonio Vazquez (antoniov) mentioned this in T96241: 3.1: Potential candidates for corrective releases.
Philipp Oeser (lichtwerk) added a commit: rBbac78e9bbe1f: Fix T96828: GPencil primitives handlers not working.Mar 28 2022, 4:27 PM