Maniphest T97019

Regression: Grease pencil Shrinkwrap modifier no longer working
Closed, ResolvedBUG
Actions

Assigned To
Antonio Vazquez (antoniov)
Authored By
Aleš Jelovčan (frogstomp)
Apr 4 2022, 9:15 AM
Tags
  • BF Blender
  • Grease Pencil
Subscribers
Aleš Jelovčan (frogstomp)
Antonio Vazquez (antoniov)
Henrik Dick (weasel)
Pratik Borhade (PratikPB2123)

Description

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce MX330/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.91

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-03 08:49, hash: rB1cdf8b19e588
Worked: 3.1
Short description of error
GP Shrinkwrap modifier has no effect

Exact steps for others to reproduce the error
1.) Add mesh object (Subdivided Cube)
2.) Add GP object (Suzanne)
3.) Add Shrinkwrap modifier, select mesh, no effect

The bug was introduced in d4e1458db3a0e0eaf80219dc8e6d10cb27620793

Revisions and Commits

rB Blender
D14548rB5eab5713c023 Fix T97019: Regression - GPencil Shrinkwrap modifier not longer working

Related Objects

Event Timeline

Aleš Jelovčan (frogstomp) created this task.Apr 4 2022, 9:15 AM
Omar Emara (OmarSquircleArt) changed the task status from Needs Triage to Confirmed.Apr 4 2022, 10:08 AM
Omar Emara (OmarSquircleArt) added a project: Grease Pencil.
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Apr 4 2022, 2:06 PM

I can reproduce it.

@Aleš Jelovčan (frogstomp) Do you know the last day that this modifier worked? The GP code has not changed, so must be a chnage in other area.

Antonio Vazquez (antoniov) renamed this task from Grease pencil Shrinkwrap modifier no longer working to Regression; Grease pencil Shrinkwrap modifier no longer working.Apr 4 2022, 2:06 PM
Antonio Vazquez (antoniov) renamed this task from Regression; Grease pencil Shrinkwrap modifier no longer working to Regression: Grease pencil Shrinkwrap modifier no longer working.
Antonio Vazquez (antoniov) changed the subtype of this task from "Report" to "Bug".
Aleš Jelovčan (frogstomp) added a comment.Apr 4 2022, 2:31 PM

Not sure, last time I used it was 2 weeks ago I think.
I'm building now with commits before/after Envelope was introduced.. those were the last two modifiers added so maybe the issue is there, will report back.

Aleš Jelovčan (frogstomp) added a comment.Apr 4 2022, 3:06 PM

Still works after Envelope was added. I'll be moving 10 commits up towards master and building to narrow it down.

Antonio Vazquez (antoniov) assigned this task to Henrik Dick (weasel).Apr 4 2022, 4:48 PM
Antonio Vazquez (antoniov) updated the task description.
Antonio Vazquez (antoniov) added a subscriber: Henrik Dick (weasel).

The commit with the new Smooth is the reason of the bug. If you remove the function BKE_gpencil_stroke_smooth_point the modifier works.

@Henrik Dick (weasel) Not sure if you could just smooth the whole stroke at the end, instead to smooth each point.

Antonio Vazquez (antoniov) claimed this task.Apr 4 2022, 4:59 PM
Antonio Vazquez (antoniov) added a revision: D14548: Proposed fix for T97019.
Antonio Vazquez (antoniov) triaged this task as High priority.Apr 4 2022, 5:28 PM
Henrik Dick (weasel) added a comment.Apr 4 2022, 5:35 PM

Yes, this is caused by me. If you take a look at the removed lines in D14548 you can see how the code was doing the smooth based on the original stroke and not on the new position data. So the result was a slight smooth and nothing else.

Antonio Vazquez (antoniov) closed this task as Resolved by committing rB5eab5713c023: Fix T97019: Regression - GPencil Shrinkwrap modifier not longer working.Apr 4 2022, 10:34 PM
Antonio Vazquez (antoniov) added a commit: rB5eab5713c023: Fix T97019: Regression - GPencil Shrinkwrap modifier not longer working.
Antonio Vazquez (antoniov) mentioned this in T96241: 3.1: Potential candidates for corrective releases.Apr 4 2022, 10:35 PM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Apr 5 2022, 4:26 AM

@Antonio Vazquez (antoniov) , AFAICT 3.1.2 was the last corrective release. So mentioning the fix in T96241 is of no use (double check with Philipp or Thomas)
I doubt 3.1 is also affected because responsible commit was not merged in 3.1 branch

Antonio Vazquez (antoniov) added a comment.Apr 5 2022, 12:56 PM

@Pratik Borhade (PratikPB2123) Yes, I know...I added by error to the task of 3.1. I have removed it this morning. ;-)