Maniphest T101445

Regression: halo Particles are not working.
Closed, Resolved
Actions

Assigned To
Everton Schneider (eversimo)
Authored By
Everton Schneider (eversimo)
Sep 29 2022, 3:19 AM
Tags
  • BF Blender
  • Nodes & Physics
  • EEVEE & Viewport
Subscribers
Alexey (pseudoua)
Clément Foucault (fclem)
Constantine Vojik (costavojik)
Everton Schneider (eversimo)
Jason Fielder (jason_apple)
Keith Boshoff (wahooney)
Michael Parkin-White (MichaelPW)
2 More Subscribers

Description

System Information
Operating system: Linux-5.15.0-48-generic-x86_64-with-glibc2.35 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.65.01

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-28 17:36, hash: rBad789c74df49
Worked: 3.3
Caused by rB18b45aabf91a: Metal: GLSL shader compatibility changes for global uniform and interface name…

Short description of error
There are no particles after adding a particle system.

Exact steps for others to reproduce the error

  • Simply select the default cube
  • Add a particle system
  • And press play. No particles.

If you set the render mode as object and use an object to render the particle it works, particles are there. I guess that the halo particles are not getting into account to display in the viewport...

Revisions and Commits

rB Blender
D16236rBd3b47fa84297 FIX T101445: halo Particles are not working.

Related Objects

Mentioned In
T101839: Fluid simulation not working
T101771: Viewport particles are broken
Mentioned Here
D16236: FIX T101445: halo Particles are not working.
rB18b45aabf91a: Metal: GLSL shader compatibility changes for global uniform and interface name…

Event Timeline

Everton Schneider (eversimo) created this task.Sep 29 2022, 3:19 AM
Everton Schneider (eversimo) updated the task description.Sep 29 2022, 3:29 AM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Sep 29 2022, 4:40 AM
Pratik Borhade (PratikPB2123) triaged this task as High priority.
Pratik Borhade (PratikPB2123) added a project: Nodes & Physics.
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).
Pratik Borhade (PratikPB2123) renamed this task from Particles are not working. to Regression: halo Particles are not working..Sep 29 2022, 5:24 AM
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) added a project: EEVEE & Viewport.
Pratik Borhade (PratikPB2123) added subscribers: Jason Fielder (jason_apple), Clément Foucault (fclem).

Broken since rB18b45aabf91a: Metal: GLSL shader compatibility changes for global uniform and interface name…
cc @Jason Fielder (jason_apple)
cc @Clément Foucault (fclem)

Michael Parkin-White (MichaelPW) added a subscriber: Michael Parkin-White (MichaelPW).Sep 29 2022, 4:46 PM
Michael Parkin-White (MichaelPW) added a comment.Sep 29 2022, 5:48 PM

Will take a look at this. Likely a uniform assignment update was missed.

Unknown Object (User) mentioned this in T101771: Viewport particles are broken.Oct 12 2022, 1:34 PM
Omar Emara (OmarSquircleArt) merged a task: T101771: Viewport particles are broken.Oct 12 2022, 1:37 PM
Omar Emara (OmarSquircleArt) added subscribers: Constantine Vojik (costavojik), Unknown Object (User), Omar Emara (OmarSquircleArt).
Omar Emara (OmarSquircleArt) merged a task: T101774: Fluid sim doesn't create fluid particles in 3.4.Oct 12 2022, 2:43 PM
Omar Emara (OmarSquircleArt) added a subscriber: Keith Boshoff (wahooney).
Jason Fielder (jason_apple) added a revision: D16236: FIX T101445: halo Particles are not working..Oct 12 2022, 4:14 PM
Pratik Borhade (PratikPB2123) assigned this task to Jason Fielder (jason_apple).Oct 15 2022, 6:14 AM
Unknown Object (User) mentioned this in T101839: Fluid simulation not working.Oct 15 2022, 10:13 AM
Pratik Borhade (PratikPB2123) merged a task: T101839: Fluid simulation not working.Oct 15 2022, 12:09 PM
Pratik Borhade (PratikPB2123) added a subscriber: Alexey (pseudoua).
Unknown Object (User) added a comment.Oct 15 2022, 12:21 PM
This comment was removed by Unknown Object (User).
Michael Parkin-White (MichaelPW) reassigned this task from Jason Fielder (jason_apple) to Everton Schneider (eversimo).Oct 15 2022, 10:12 PM

A fix should be present in the above revision: https://developer.blender.org/D16236, though I don't believe this is yet merged.
This was due to an oversight in the code for avoiding variable namespace pollution, wherein a resource binding (uniform/vertex attribute etc) shared the same name as a local variable or function parameter. The shader uniform and create info had been updated, but the uniform assignment for this one shader had been missed.

Though please verify that applying this DIFF works, thanks!

Clément Foucault (fclem) added a commit: rBd3b47fa84297: FIX T101445: halo Particles are not working..Oct 17 2022, 5:47 PM
Miguel Pozo (pragma37) added a subscriber: Miguel Pozo (pragma37).Nov 7 2022, 5:45 PM

So... this is actually solved, right?


Any reason for not closing this?

Clément Foucault (fclem) closed this task as Resolved.Nov 7 2022, 8:24 PM

I guess the capitalization of FIX in the commit title did not auto close the ticket.