Maniphest T101694

Regression: Sculpting Faceset menu: SHOW_ALL not found error
Closed, ResolvedBUG
Actions

Assigned To
Pratik Borhade (PratikPB2123)
Authored By
Reiner Prokein (tiles)
Oct 8 2022, 11:03 AM
Tags
  • BF Blender
  • Sculpt, Paint & Texture
  • User Interface
Subscribers
Pratik Borhade (PratikPB2123)
Reiner Prokein (tiles)

Description

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.15

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-06 06:33, hash: rB0484b6bb1816
Worked: (newest version of Blender that worked as expected)

Short description of error
Console thows an error when you sue Show All Face Sets in the Face Sets menu.

Exact steps for others to reproduce the error

  • Open Blender
  • Switch to Sculpt mode
  • In Face sets menu choose Show All Face Sets
  • Watch the console

Show all does not longer exist in the enum.

Revisions and Commits

rB Blender
D16199rB9a6dc39d4b85 Sculpt: Fix T101694: Change operator for unhide face sets

Related Objects

Event Timeline

Reiner Prokein (tiles) created this task.Oct 8 2022, 11:03 AM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Oct 9 2022, 5:49 AM
Pratik Borhade (PratikPB2123) claimed this task.
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).

Thanks for the report. I can confirm. Will check for the fix and commit that causes the problem

Pratik Borhade (PratikPB2123) renamed this task from Sculpting - Facesets menu - SHOW_ALL not found error to Regression: Sculpting Faceset menu: SHOW_ALL not found error.Oct 9 2022, 6:02 AM
Pratik Borhade (PratikPB2123) triaged this task as High priority.
Pratik Borhade (PratikPB2123) added a revision: D16199: Fix T101694: Change operator for unhide face sets.
Pratik Borhade (PratikPB2123) added projects: Sculpt, Paint & Texture, User Interface.

Caused by: rB22c3db72ca2f: Sculpt: Visibility bugfixes
Fix: D16199: Fix T101694: Change operator for unhide face sets

Reiner Prokein (tiles) mentioned this in T101707: Crash to desktop in Sculpt mode with Show all Face Sets.Oct 9 2022, 8:38 AM
Pratik Borhade (PratikPB2123) merged a task: T101707: Crash to desktop in Sculpt mode with Show all Face Sets.Oct 9 2022, 8:50 AM
Reiner Prokein (tiles) added a comment.EditedOct 9 2022, 9:37 AM

Toying around with it. Just curious, what is with the other possible operators? We have four operators in the enum. But just two of them in the menu now. Invert Visible and Show Active Face Sets. And the other two operators still crashes when i add them to the menu.
layout.operator("sculpt.face_set_change_visibility", text='Hide Active Face Sets').mode = 'HIDE_ACTIVE'
layout.operator("sculpt.face_set_change_visibility", text='Toggle Visibility').mode = 'TOGGLE'
To what do i need to change them now so that they don't crash?

Reiner Prokein (tiles) added a comment.Oct 9 2022, 9:46 AM

Oh and performing show active face sets from the enum in the last operator still says this in the info editor:

bpy.ops.sculpt.face_set_change_visibility(mode='SHOW_ACTIVE')

And a last question, shouldn't
op = layout.operator("sculpt.reveal_all", text='Show All Face Sets')
simply be
layout.operator("sculpt.reveal_all", text='Show All Face Sets')

No need for the op variable when there are no more arguments :)

Julien Kaspar (JulienKaspar) moved this task from Backlog to Bugs on the Sculpt, Paint & Texture board.Oct 10 2022, 1:02 PM
Julien Kaspar (JulienKaspar) changed the subtype of this task from "Report" to "Bug".
Joseph Eagar (joeedh) closed this task as Resolved by committing rB9a6dc39d4b85: Sculpt: Fix T101694: Change operator for unhide face sets.Oct 11 2022, 11:49 AM
Joseph Eagar (joeedh) added a commit: rB9a6dc39d4b85: Sculpt: Fix T101694: Change operator for unhide face sets.