Maniphest T101722

Regression: Missing default face set for primitive meshes
Closed, Resolved
Actions

Assigned To
Hans Goudey (HooglyBoogly)
Authored By
Pratik Borhade (PratikPB2123)
Oct 10 2022, 12:56 PM
Tags
  • BF Blender
  • Sculpt, Paint & Texture
Subscribers
Hans Goudey (HooglyBoogly)
Omar Emara (OmarSquircleArt)
Pratik Borhade (PratikPB2123)
TheRedWaxPolice (TheRedWaxPolice)

Description

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.78

Blender Version
Broken: builds before rB22c3db72ca2f or apply D16206 on master
Worked: 3.3
First bad commit: {b5f7af31d6d474c3b455bacda079969fde7c0962}

Short description of error
I guess default face set for primitive meshes are missing.
Because calling Hide active face sets doesn't hide the mesh. It works though for Default cube

Exact steps for others to reproduce the error

  • Open default scene
  • delete cube and add new mesh
  • Switch to sculpt mode
  • Press ⇧+H to hide all face sets

Found this issue while bisecting T101699: Regression: Crash in sculpt mode using shift+h

Related Objects

Mentioned In
T101699: Regression: Crash in sculpt mode using shift+h
Mentioned Here
rBda25006bc4c7: Sculpt: T101699: Face set change visibility crashes on no face sets
T101699: Regression: Crash in sculpt mode using shift+h
rBb5f7af31d6d4: When these features aren't used, there is no sense in storing the
rB22c3db72ca2f: Sculpt: Visibility bugfixes
D16206: Fix T101699: Crash on hiding all face sets

Event Timeline

Pratik Borhade (PratikPB2123) created this task.Oct 10 2022, 12:56 PM
Pratik Borhade (PratikPB2123) added a subscriber: Hans Goudey (HooglyBoogly).
Pratik Borhade (PratikPB2123) updated the task description.Oct 10 2022, 1:03 PM
Pratik Borhade (PratikPB2123) mentioned this in T101699: Regression: Crash in sculpt mode using shift+h .
Omar Emara (OmarSquircleArt) changed the task status from Needs Triage to Confirmed.Oct 10 2022, 4:01 PM
Omar Emara (OmarSquircleArt) triaged this task as High priority.
Omar Emara (OmarSquircleArt) added a project: Sculpt, Paint & Texture.
Omar Emara (OmarSquircleArt) added a subscriber: Omar Emara (OmarSquircleArt).

I hit an assert as well:

BLI_assert failed: source/blender/editors/sculpt_paint/sculpt.c:372, SCULPT_face_set_visibility_set(), at 'ss->face_sets != ((void*)0)'
Pratik Borhade (PratikPB2123) added a comment.Oct 10 2022, 4:29 PM
In T101722#1430215, @Omar Emara (OmarSquircleArt) wrote:

I hit an assert as well:

BLI_assert failed: source/blender/editors/sculpt_paint/sculpt.c:372, SCULPT_face_set_visibility_set(), at 'ss->face_sets != ((void*)0)'

yes, thanks different issue :)
see: T101699: Regression: Crash in sculpt mode using shift+h

Hans Goudey (HooglyBoogly) claimed this task.Oct 10 2022, 5:14 PM
TheRedWaxPolice (TheRedWaxPolice) added a subscriber: TheRedWaxPolice (TheRedWaxPolice).Oct 11 2022, 3:59 AM
Pratik Borhade (PratikPB2123) renamed this task from Missing default face set for primitive meshes to Regression: Missing default face set for primitive meshes.Oct 11 2022, 10:59 AM
Pratik Borhade (PratikPB2123) added a comment.Oct 11 2022, 11:08 AM

Unable to redo this anymore in current master. Can someone confirm?
Probably fixed by rBda25006bc4c7: Sculpt: T101699: Face set change visibility crashes on no face sets

Omar Emara (OmarSquircleArt) added a comment.Oct 11 2022, 11:25 AM

Can't redo on latest master either.

Pratik Borhade (PratikPB2123) closed this task as Resolved.Oct 11 2022, 11:33 AM

Thanks :)
Will close the report