Maniphest T101913

Regression: panels in the properties panel lose their place when scrolling one of the other property panels.
Confirmed, Normal

Assigned To
Hans Goudey (HooglyBoogly)
Authored By
michael campbell (3di)
Oct 18 2022, 11:55 PM
Tags
  • BF Blender
  • User Interface
Subscribers
Hans Goudey (HooglyBoogly)
Iliya Katueshenock (Moder)
michael campbell (3di)
Philipp Oeser (lichtwerk)
Pratik Borhade (PratikPB2123)

Description

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.96

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-08 18:43, hash: rBcee6c07f9ee8
Broken: 2.91
Worked: 2.90

This is caused by rB940b239ad473: Cleanup: Remove unused variables for horizontal panels

Short description of error
When we scroll down in any panel and switch to another panel then changing back to previous panel will reset its position (i.e. to the top)

Exact steps for others to reproduce the error

Related Objects

Mentioned Here
rB5c78c16b1494: UI: Simplify cloth filter type description
rB940b239ad473: Cleanup: Remove unused variables for horizontal panels

Event Timeline

michael campbell (3di) created this task.Oct 18 2022, 11:55 PM
Iliya Katueshenock (Moder) added a subscriber: Iliya Katueshenock (Moder).Oct 19 2022, 12:01 AM

It seemed to me that in all editors with 2d positioning, when you switch scopes/tabs/groups you keep the position. And if this position is truncated because your interface has become smaller and does not scroll, then in all the rest you will be higher.

Iliya Katueshenock (Moder) closed this task as Archived.Oct 19 2022, 12:02 AM
michael campbell (3di) added a comment.Oct 19 2022, 1:48 AM

yes, that's what I'm saying. It's still a bug though right?

Iliya Katueshenock (Moder) added a comment.Oct 19 2022, 7:18 AM

Is this a request to remove the global position in the interface?

michael campbell (3di) added a comment.Oct 19 2022, 8:00 AM

Well that would be nice, but it doesn't seem to be related to this bug. The behaviour is correct until the panel switched to is sufficiently condensed to not be scrollable. So the panels are working correctly until that occurrence. Doesn't appear to be anything to do with the global position of things like the node editors for example.

So it's obviously been designed to remember the positioning when switching between tabs on the same panel, it's just not working after switching to a tab that can't scroll and then back again.

I'm not being funny, but you seem to be closing down bug reports like they're a nuisance. I think you should remember that people reporting bugs are going to some effort to try and help make the software better.

Iliya Katueshenock (Moder) added a comment.Oct 19 2022, 10:59 AM

That the coordinate is truncated is normal behavior. It has always been so. This report is not a bug, but a request to change this behavior. Which is everywhere.

Iliya Katueshenock (Moder) added a comment.EditedOct 19 2022, 11:02 AM

The job of a bug tracker is to report bugs. In order to make the program better, write suggestions (on RCS), or if you are a developer, design.

Philipp Oeser (lichtwerk) reopened this task as Needs Triage.Oct 19 2022, 12:26 PM
Philipp Oeser (lichtwerk) added a project: User Interface.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).
In T101913#1434294, @Iliya Katueshenock (Moder) wrote:

It has always been so

Hm, dont think so.
If you do this in 2.90, it stays scrolled down after switching back to the tab
If you do this in 2.91, the behavior changed to the behavior described in this report.

We should at least check why/when this changed (because at first sight, this does not necessarily look like an improvement)

Philipp Oeser (lichtwerk) updated the task description.Oct 19 2022, 12:39 PM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Oct 19 2022, 2:33 PM
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).

I'll mark this report as confirmed for now.
@Philipp Oeser (lichtwerk) , do you've closest good and bad versions?

Philipp Oeser (lichtwerk) added a comment.Oct 20 2022, 9:43 AM

good rB5c78c16b1494
bad rB940b239ad473
Will try to bisect myself.

Philipp Oeser (lichtwerk) added a subscriber: Hans Goudey (HooglyBoogly).Oct 20 2022, 10:37 AM

This is caused by rB940b239ad473: Cleanup: Remove unused variables for horizontal panels

So seems like an unintentional change, @Hans Goudey (HooglyBoogly) , mind checking?

Philipp Oeser (lichtwerk) renamed this task from panels in the properties panel lose their place when scrolling one of the other property panels. to Regression: panels in the properties panel lose their place when scrolling one of the other property panels..Oct 20 2022, 10:38 AM
Philipp Oeser (lichtwerk) updated the task description.
Hans Goudey (HooglyBoogly) claimed this task.Oct 20 2022, 2:39 PM
Iliya Katueshenock (Moder) added a comment.EditedOct 20 2022, 2:46 PM

Wow. I'm sorry that I took it as something planned from the very beginning. I'll be watching more to see if another something like this has happened before.