Maniphest T104313

Custom nodes appear in search results for tree types that don't support them
Needs Information from User, Normal
Actions

Assigned To
None
Authored By
Netherby (netherby)
Fri, Feb 3, 1:06 AM
Tags
  • BF Blender
  • Nodes & Physics
  • Python API
Subscribers
Leon Schittek (lone_noel)
Netherby (netherby)
Pratik Borhade (PratikPB2123)
• spam (CarlottaKrajcik)
Thomas Dinges (dingto)

Description

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 3.4.0, branch: blender-v3.4-release, commit date: 2022-12-06 18:46, hash: rBa95bf1ac01be
Worked: 3.3

Short description of error
Custom nodes created for custom node trees now appear in the search results when adding nodes to the built-in tree types (Shader, Geometry, etc)

Exact steps for others to reproduce the error
Exact steps are somewhat complicated since you need to have python script create a custom node tree type along with nodes to go in it and register them... But if you have an add-on or script that creates custom nodes not meant to show up in the Shader node tree and search for them by name while in the Shader node editor they now appear in the search results and can be added to the tree since 3.4. In the previous version they did not appear in search results and could not be added in this way.

Related Objects

Event Timeline

Netherby (netherby) created this task.Fri, Feb 3, 1:06 AM
Iliya Katueshenock (Moder) added projects: Nodes & Physics, Python API.Fri, Feb 3, 1:07 AM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Needs Information from User.Fri, Feb 3, 6:05 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).

Hi, thanks for the report. Can not reproduce here with python Custom Node template.
Could you check again in latest 3.5 builds with factory settings?: https://builder.blender.org/download/daily/

Leon Schittek (lone_noel) added a subscriber: Leon Schittek (lone_noel).Fri, Feb 3, 6:19 AM

Hi, there was a report similar to this a while a go in T101259. @Netherby (netherby), could you check if that sounds like the same issue to you?
If that's the case, you might need to update your custom nodes. There was a solution discussed in the comments, see T101259#1423746 and the few posts following

• spam (CarlottaKrajcik) added a subscriber: • spam (CarlottaKrajcik).Fri, Feb 3, 6:49 AM
This comment was removed by Thomas Dinges (dingto).
Thomas Dinges (dingto) added a subscriber: Thomas Dinges (dingto).Fri, Feb 3, 11:42 AM
Netherby (netherby) added a comment.EditedSat, Feb 4, 10:47 PM

Yes this appears to be the same issue where the template order causes the problem. Using the 'Custom Nodes' template included in Blender, having the node class defined as

class MyCustomNode(Node, MyCustomTreeNode): # Node appears incorrectly in search

class MyCustomNode(MyCustomTreeNode, Node): # Now is hidden as expected

Previously examples showed the order as the first case.. Going forward, I assume the Blender class should always be the last template in custom nodes and sockets?